deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 10:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 310 - lanplus retry regression

Browse Source 
The lanplus driver for has a bug in ipmi_lanplus_open_session(). There is
an extra and undesired check for a null response (timeout). As a result, it
returns 1 to the caller. The result of this is an occasional assertion. Commit
mends this.

Commit for Pat Donlin
This commit is contained in:
Zdenek Styblik 2014-04-25 20:40:36 +02:00
parent 9d88837ef3
commit 4f0967779e
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/lanplus/lanplus.c
View File

@ -2882,17 +2882,13 @@ ipmi_lanplus_open_session(struct ipmi_intf * intf)
free(msg); free(msg);
msg = NULL; msg = NULL;
if (!rsp) {
lprintf(LOG_WARNING, "Error sending open session message.");
return -1;
}
if (verbose)
lanplus_dump_open_session_response(rsp);
if (rsp == NULL ) { if (rsp == NULL ) {
lprintf(LOG_DEBUG, "Timeout in open session response message."); lprintf(LOG_DEBUG, "Timeout in open session response message.");
return 2; return 2;
} }
if (verbose)
lanplus_dump_open_session_response(rsp);
if (rsp->payload.open_session_response.rakp_return_code != if (rsp->payload.open_session_response.rakp_return_code !=
IPMI_RAKP_STATUS_NO_ERRORS) IPMI_RAKP_STATUS_NO_ERRORS)
{ {