deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 10:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 50 - ipmi_hpmfwupg needs a clean up

Browse Source 
* print error if not enough parameters given, return code 1
* recognize 'help' as a valid parameter
* print error if a invalid parameter is given, return code 1
This commit is contained in:
Zdenek Styblik 2013-10-26 06:55:18 +00:00
parent 45d0a4255a
commit b782311e10
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ipmitool/lib/ipmi_hpmfwupg.c
View File

@ -2469,11 +2469,15 @@ ipmi_hpmfwupg_main(struct ipmi_intf *intf, int argc, char **argv)
lprintf(LOG_NOTICE, "\nPICMG HPM.1 Upgrade Agent %d.%d.%d: \n",
HPMFWUPG_VERSION_MAJOR, HPMFWUPG_VERSION_MINOR,
HPMFWUPG_VERSION_SUBMINOR);
if ((argc == 0) || (strcmp(argv[0], "help") == 0)) {
if (argc < 1) {
lprintf(LOG_ERR, "Not enough parameters given.");
HpmfwupgPrintUsage();
return HPMFWUPG_ERROR;
}
if ((strcmp(argv[0], "check") == 0)) {
if (strcmp(argv[0], "help") == 0) {
HpmfwupgPrintUsage();
return HPMFWUPG_SUCCESS;
} else if ((strcmp(argv[0], "check") == 0)) {
/* hpm check */
if (argv[1] == NULL) {
rc = HpmfwupgTargetCheck(intf,VIEW_MODE);
@ -2633,7 +2637,9 @@ ipmi_hpmfwupg_main(struct ipmi_intf *intf, int argc, char **argv)
verbose++;
rc = HpmfwupgQuerySelftestResult(intf, &cmdCtx, NULL);
} else {
lprintf(LOG_ERR, "Invalid HPM command: %s", argv[0]);
HpmfwupgPrintUsage();
rc = HPMFWUPG_ERROR;
}
return rc;
}