Zdenek Styblik
1cc4ba699d
ID: 46 - ipmi_fwum needs some re-work
...
Move 'struct' and 'enum' into header file
2013-10-26 19:31:44 +00:00
Zdenek Styblik
b779439ad0
ID: 46 - ipmi_fwum needs some re-work
...
Replace tKFWUM_Status with int
Commit replaces tKFWUM_Status with int. tKFWUM_Status is all nice and neat, but
if int can do, why would you use something that makes your lines unnecessarily
longer?
2013-10-26 19:30:15 +00:00
Zdenek Styblik
63ef18e6e0
ID: 46 - ipmi_fwum needs some re-work
...
Remove keyword 'static'
Commit removes ``static'' as I see no point, no point at all to have it here.
2013-10-26 19:29:49 +00:00
Zdenek Styblik
935b215514
ID: 46 - ipmi_fwum needs some re-work
...
Rename saveFirmwareInfo -> save_fw_nfo
2013-10-26 19:29:29 +00:00
Zdenek Styblik
cd524c2d25
ID: 46 - ipmi_fwum needs some re-work
...
File name is no longer ``uchar *'' - remove casts
File name is no longer ``unsigned char *'', therefore remove pointless casts to
``char *''.
2013-10-26 19:29:05 +00:00
Zdenek Styblik
e24c7f75f2
ID: 46 - ipmi_fwum needs some re-work
...
Remove duplicate Kontron IANA number
Commit removes/replaces duplicate Kontron IANA number which can be found in
'include/ipmitool/ipmi.h' as well. Therefore there is no need to have it here.
2013-10-26 19:28:40 +00:00
Zdenek Styblik
da4b779adf
ID: 46 - ipmi_fwum needs some re-work
...
Group together and order[a-z] function prototypes
2013-10-26 19:27:43 +00:00
Zdenek Styblik
aca8d6ad7b
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - download/upgrade fw
Commit removes KfwumMain() and creates ipmi_fwum_fwupgrade() instead.
2013-10-26 19:27:15 +00:00
Zdenek Styblik
5416af78a5
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - start fw upgrade
Commit moves start-fw-upgrade out of KfwumMain(). It also changes return type of
KfwumStartFirmwareUpgrade().
2013-10-26 19:26:38 +00:00
Zdenek Styblik
770e61663f
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - tracelog
Commit moves tracelog out of KfwumMain() and changes return type of
KfwumGetTraceLog().
2013-10-26 19:26:16 +00:00
Zdenek Styblik
22f294fc27
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - status
Commit moves status out of KfwumMain().
2013-10-26 19:25:16 +00:00
Zdenek Styblik
a675601da4
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - info
Commit moves 'info' out of KfwumMain().
2013-10-26 19:24:02 +00:00
Zdenek Styblik
645120f545
ID: 46 - ipmi_fwum needs some re-work
...
Dismantle KfwumMain() - rollback
Commit moves 'rollback' out of KfwumMain() and changes return value of
KfwumManualRollback().
2013-10-26 19:23:37 +00:00
Zdenek Styblik
2df9ca914f
ID: 46 - ipmi_fwum needs some re-work
...
KfwumMain() - return value void -> int
KfwumMain() returns int instead of void now in order to report success or
failure of given task.
2013-10-26 19:23:16 +00:00
Zdenek Styblik
a5d55b5d51
ID: 46 - ipmi_fwum needs some re-work
...
Move #define into header file
2013-10-26 19:20:50 +00:00
Zdenek Styblik
f2ba7fcd60
ID: 46 - ipmi_fwum needs some re-work
...
Rename VERSION_MAJ and VERSION_MIN
Commit renames VERSION_MAJ to VER_MAJOR and VERSION_MIN to VER_MINOR.
2013-10-26 19:18:34 +00:00
Zdenek Styblik
24923222f6
ID: 46 - ipmi_fwum needs some re-work
...
Finish off formatting, remove useless comments
Commit finishes off formatting changes and removes useless, out-of-date,
comments.
2013-10-26 19:18:01 +00:00
Zdenek Styblik
5bf68a4769
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetInfoFromFirmware() - code formatting, simplify
2013-10-26 19:16:36 +00:00
Zdenek Styblik
4e2ac7d097
ID: 46 - ipmi_fwum needs some re-work
...
KfwumOutputInfo() -> printf_kfwum_info() + code formatting
2013-10-26 19:15:15 +00:00
Zdenek Styblik
d5d86d4dcb
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetTraceLog() - code formatting, simplification
2013-10-26 19:14:43 +00:00
Zdenek Styblik
0a4a5cafbc
ID: 46 - ipmi_fwum needs some re-work
...
KfwumStartFirmwareUpgrade() - code formatting
2013-10-26 19:13:43 +00:00
Zdenek Styblik
043c42160e
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetStatus() - formatting, simplify, documentation
2013-10-26 19:12:44 +00:00
Zdenek Styblik
49879b387c
ID: 46 - ipmi_fwum needs some re-work
...
KfwumShowProgress() - code formatting, fix
Commit fixes code formatting in KfwumShowProgress() and replaces ``unsigned
char'', which didn't make any sense, with a ``signed char'', resp. ``char''.
2013-10-26 19:11:33 +00:00
Zdenek Styblik
38121041c1
ID: 46 - ipmi_fwum needs some re-work
...
KfwumUploadFirmware() - code formatting
2013-10-26 19:10:16 +00:00
Zdenek Styblik
d8f27165d1
ID: 46 - ipmi_fwum needs some re-work
...
KfwumFinishFirmareImage() - code formatting
2013-10-26 19:09:15 +00:00
Zdenek Styblik
5a1e81a948
ID: 46 - ipmi_fwum needs some re-work
...
KfwumSaveFirmwareImage() - formatting, clean-up
Commit cleans up formatting, code and, hopefully, simplifies
KfwumSaveFirmwareImage().
2013-10-26 19:08:12 +00:00
Zdenek Styblik
f12b976ebc
ID: 46 - ipmi_fwum needs some re-work
...
KfwumStartFirmwareImage() - code formatting, simplify
2013-10-26 19:07:04 +00:00
Zdenek Styblik
0dddcfe450
ID: 46 - ipmi_fwum needs some re-work
...
KfwumManualRollback() - code formatting, simplify
2013-10-26 19:06:28 +00:00
Zdenek Styblik
700658e91e
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetDeviceInfo() - simplify, code formatting
2013-10-26 19:04:42 +00:00
Zdenek Styblik
3df72b68bc
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetInfo() - simplify logic, code formatting
2013-10-26 19:03:54 +00:00
Zdenek Styblik
068bcb02e4
ID: 46 - ipmi_fwum needs some re-work
...
Rename KfwumValidFirmwareForBoard(), document
Commit renames KfwumValidFirmwareForBoard() to ipmi_kfwum_checkfwcompat() and
adds a bit of documentation about this function.
Code formatting of this function changed as well.
2013-10-26 18:38:24 +00:00
Zdenek Styblik
52634a708f
ID: 46 - ipmi_fwum needs some re-work
...
KfwumGetFileSize() - small re-work
2013-10-26 18:37:45 +00:00
Zdenek Styblik
2b08fd405e
ID: 46 - ipmi_fwum needs some re-work
...
KfwumMain() - change code formatting
Commit changes code formatting of KfwumMain() into readable form and to make
sense out of it.
2013-10-26 18:37:00 +00:00
Zdenek Styblik
fb3c6f292e
ID: 46 - ipmi_fwum needs some re-work
...
Rename KfwumOutputHelp() to printf_kfwum_help()
2013-10-26 18:35:44 +00:00
Zdenek Styblik
d02492f1c7
ID: 46 - ipmi_fwum needs some re-work
...
Remove trailing tabs and white spaces.
2013-10-26 17:12:29 +00:00
Zdenek Styblik
9517cb332b
ID: 46 - ipmi_fwum needs some re-work
...
ipmi_fwum_main() re-work.
2013-10-26 17:10:14 +00:00
Zdenek Styblik
ae96dd3229
ID: 50 - ipmi_hpmfwupg needs a clean up
...
I really don't believe you meant 'static' + function(), seriously.
2013-10-26 14:40:05 +00:00
Zdenek Styblik
968f5d6552
ID: 50 - ipmi_hpmfwupg needs a clean up
...
Rather major re-work of internal logic in HpmfwupgPreparationStage().
2013-10-26 14:18:48 +00:00
Zdenek Styblik
f4730e1f67
ID: 50 - ipmi_hpmfwupg needs a clean up
...
ComponentId has its own declaration now.
2013-10-26 07:08:13 +00:00
Zdenek Styblik
b782311e10
ID: 50 - ipmi_hpmfwupg needs a clean up
...
* print error if not enough parameters given, return code 1
* recognize 'help' as a valid parameter
* print error if a invalid parameter is given, return code 1
2013-10-26 06:55:18 +00:00
Jim Mankovich
45d0a4255a
ID: #279 ipmitool sdr list broken
...
Restoration of the interface target address and channel after a bridged
request was incorrectly tied to a non-zero saved target address. This does
not work for the Openipmi interface because the default interface target address
for the Openipmi interface is zero by default.
2013-10-23 20:32:40 +00:00
Zdenek Styblik
ac9513025c
ID: 50 - ipmi_hpmfwupg needs a clean up
...
Remove "changelog". That's why we have tickets, SCM, ChangeLog etc.
2013-10-11 04:45:55 +00:00
Zdenek Styblik
60a3e63429
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgQuerySelftestResult() - kill one level of indentation.
2013-10-11 04:14:59 +00:00
Zdenek Styblik
f19ed0a90b
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgUpgradeStage() - kill one level of indentation by changing one if().
2013-10-10 12:26:46 +00:00
Zdenek Styblik
7a0b451fd7
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgValidateImageIntegrity() - re-write a bit to make it more compact.
2013-10-10 12:17:22 +00:00
Zdenek Styblik
a8119d13a8
ID: 50 - ipmi_hpmfwupg needs a clean up
...
Add missing ``rsp == NULL'' comp.
2013-10-10 12:06:00 +00:00
Zdenek Styblik
f56cea1253
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgQueryRollbackStatus() - kill one level of indentation.
2013-10-10 12:04:52 +00:00
Zdenek Styblik
7b5683d85d
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgManualFirmwareRollback() - kill one level of indentation.
2013-10-10 11:56:04 +00:00
Zdenek Styblik
80c03570ac
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgActivateFirmware(), HpmfwupgGetUpgradeStatus() - kill one level of
indentation.
2013-10-10 11:49:53 +00:00
Zdenek Styblik
6de0796079
ID: 50 - ipmi_hpmfwupg needs a clean up
...
HpmfwupgUploadFirmwareBlock() - kill a bit of indent by re-writing one if().
2013-10-10 11:42:32 +00:00