1450 Commits

Author SHA1 Message Date
Jim Mankovich
77d9e49290 added ipmitool/include/ipmi_sdradd.h to the set of files distributed
for ipmitool 1.8.12
2012-08-09 18:41:04 +00:00
Jim Mankovich
0d62e6f6e0 Update version to 1.8.12 2012-08-07 18:59:29 +00:00
Jim Mankovich
f0f9e187c9 Update change log for the 1.8.12 release 2012-08-07 18:51:35 +00:00
Jim Mankovich
89037b5158 Enable compiler warnings and resolve all compiler warning so that
ipmitool compiles and links with no warning or error messages
2012-08-03 17:07:07 +00:00
Jim Mankovich
342e71d577 Updated the Dell OEM decoding for OS Watch dog timer -type 0x23.
Support added for Post Fatal Error or Events of
sensor type 0x0F. This includes the Fatal Errors
generated from BIOS, BIOS POST, CPU and Others.


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 17:11:36 +00:00
Jim Mankovich
e196d85e43 Adding support for Dell specific sensors
IDPT memory - 0x2B. Support for status check of
communication channel between BMC/Other Hardware/CPU. Support for
Flex Address and Virtual MAC Support for  Non-Fatal
PCIE error sensor type 0xC2 and Fatal IO Error 0xC3


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 17:02:35 +00:00
Jim Mankovich
7528b89b36 Added support for sensor types - Processor related sensor
type 0x07, system incharectorization 0x20, Memory sensor type.


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 16:27:55 +00:00
Jim Mankovich
e07a644672 This patch will give more description for SEL which
is generated for Uncorrectable ECC and errors with respect to
each Memory Bank,Card or DIMM. The Sensor type
included in this patch are 0x0C and 0x10.


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 16:20:58 +00:00
Jim Mankovich
fbb778c469 Framework for decoding the Dell specific OEM Bytes from
the SEL Record. This OEM Bytes are specific to Dell
Platforms only.

Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 16:01:31 +00:00
Jim Mankovich
fdc403302d Bug fixes for delloem lan command. This includes the
support for 12G Dell license and 12G LAN Specific command.


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 15:49:23 +00:00
Jim Mankovich
3f712fe2fc Dell specific mac sub command is updated to support
the latest 12G Dell servers.
Support for virtual mac is also implemented.


Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 15:21:55 +00:00
Jim Mankovich
3631bd877c The sensor threshold values were not verified before setting
for example - if the current UNC is set to 10, one can set the UC to a value less than 10.

In this patch the values are first read and validated against the user specified values and then set.

Signed-off-by: Srinivas Gowda G <Srinivas_G_Gowda@Dell.com>
2012-07-27 15:07:11 +00:00
Jim Mankovich
0ef4c3e254 The unified sensor reading code was incorrectly returning and converting
a sensor reading when the reading/state unavailable bit was set.  This
change makes sure a valid readiing is never returned for a sensor marked
reading/state unavailable.
2012-07-23 14:52:57 +00:00
Jim Mankovich
5d960089c9 Support for analog readings in discrete sensors on HP platforms. This was
implemented without an HP oem specific switch by modifying each interface
open routine to read and cache the OEM manufacturer (via the Get Device ID
command) immediately upon open and to reset the cached OEM manufacturer
id to unknown upon interface close.  The cached manufacturer value in the
interface is then be used at run time to implement the manufacturer
specific code.

A non threshold sensor has an analog value if it is defined as having
analog units and it has either valid percentage or modifier units
defined and the manufacturer is IPMI_OEM_HP.   The determination of
whether or not a given sensor has an analog value is contained in a
single function (sdr_sensor_has_analog_reading).

This patch also encapsulates the reading of all sensor values in
ipmitool into a a single ipmitool function, ipmi_sdr_read_sensor_value.
The prior independent sensor reading code paths have been collapsed into
one sensor reading code path.   This encapsulation enabled consistent
validation of all data returned by the IPMI get sensor reading command.
In implementing a single sensor value read function, I resolved the
inconsistencies between what the "sensor" and "sdr" arguments displayed
and  I also resolved numerous cases where uninitialized information in
the IPMI reply from get sensor reading was being interpreted and
incorrectly displayed.
2012-07-10 16:01:09 +00:00
Jim Mankovich
31cb04f155 Fix exit code on '-o list' or '-o help' option
From: Jan Safranek <jsafrane@redhat.com>

'ipmitool -o list' should return zero exit code.
2012-06-05 16:58:13 +00:00
Jim Mankovich
7289f70ec9 delloem commands should not act before parsing command line.
From: Jan Safranek <jsafrane@redhat.com>

e..g 'ipmitool delloem lan help' should *not* check remote system for DELL
OEM commands before listing help. People tend to write scripts on different
machines and listing help is very helpful. In addition, why check for
setled support if only lan support is needed?
2012-06-05 16:56:39 +00:00
Jim Mankovich
4b058899a2 Fix stack overflow in delloem setled
From: Jan Safranek <jsafrane@redhat.com>

The buffer should be bigger to hold the 10 character, which are set later
in the function.
2012-06-05 16:53:09 +00:00
Jim Mankovich
79fdc68950 Fix delloem powermonitor on big-endian platforms.
From: Jan Safranek <jsafrane@redhat.com>

'ipmitool dellem powermonitor' command should convert data from
network-format to the native one, otherwise it shows garbage on ppc/ppc64
platform.
2012-06-05 16:50:18 +00:00
Jim Mankovich
6a18254c9d Add missing RMCP+ auth type strings 2012-06-05 15:55:28 +00:00
Jim Mankovich
2dfaeac27d Don't overwite the iflags bits prior to setting the boot parameters. This
fixes ipmitool so that chassis bootdev bios clear-cmos=yes will actually
clear the bios cmos.
2012-05-31 15:58:00 +00:00
Jim Mankovich
aab226da28 When using the ipmitool fru command, one of the fields displayed is the
Board Mfg Date.  This date is computed by taking the timestamp in the FRU,
which is based off of 1/1/1996 0:0:0 and adding the delta time from
1/1/1970 0:0:0 to 1/1/1996 0:0:0 so that it can be interpreted by Linux time.
This delta time is a hard-coded constant in ipmi_fru.h (secs_from_1970_1996).
This constant is incorrect.  The correct delta from those two dates should be
820454400.  This is resulting in a Board Mfg Date that is actually 1 hour
earlier than what it should be.

commited for Renzo Hayashi
2012-05-30 21:35:17 +00:00
Jim Mankovich
180aaaabbf Fix fru print so that it will display FRU info from satellite controllers.
committed for Michael Winiarski
2012-05-18 17:10:58 +00:00
Jim Mankovich
bf9406249a Document the ipmitool dcmi commands in the ipmitool man page 2012-05-17 15:52:35 +00:00
Albert Chu
56828dbaf7 fix indexing corner case 2012-05-10 16:35:33 +00:00
Jim Mankovich
219f67e41a * long lines(= lines longer than 80chars)
* validate user input in 'lib/ipmi_sunoem.c', resp. ipmi_sunoem_main()
* 'sunoem sshkey' would accept undefined actions and exit with RC = 0
* RC > 0 and help will be displayed for unknown commands/actions
* "code bumming" - some conditions seemed to be redundant

commited for Duncan Idaho
2012-05-07 14:09:28 +00:00
Jim Mankovich
62df3e6ea8 Commit handles two things
1] fail when no curses or readline is found, yet
ipmishell is about to be compiled in. ipmishell depends on these two
libraries;
2] add 'ipmishell' line to the % ./configure ; summary output to tell user
whether ipmishell support is enabled or disabled.
Committed for Duncan Idaho
2012-05-02 13:45:37 +00:00
Jim Mankovich
f1fced7ec8 Document that some commands are blocked by OpenIPMI. ID: 2962306 2012-05-02 13:31:34 +00:00
Jim Mankovich
75a7ebf5c7 Amends PICMG's help print out and changes it to ipmitool's way. It
doesn't matter whether printf() outputs at same output as LOG_NOTICE does.
Such
things should be the same for all modules.

Moves argc/help check up in the code, resp. in ipmi_picmg_main(), to
avoid unnecessary query to IPMI dev. It doesn't make sense to query IPMI
device
only to print help and terminate immediately.

Comitted for Duncan Idano
2012-05-02 13:25:04 +00:00
Jim Mankovich
53df70235f Commit removes, resp. moves further in the code, unnecessary query to IPMI
device in ipmi_lanp_main(). It doesn't make sense to query IPMI device only to
show help and terminate immediately.
Commited for Duncan Idaho
2012-05-02 13:17:04 +00:00
Jim Mankovich
8ed8ace59d changes layout of help output of 'user' sub-command. Two note-worthy
things change:
* heading has line of its own
* tabs in command-params replaced by spaces
commited for Duncan Idaho
2012-05-02 13:09:42 +00:00
Jim Mankovich
c08bded0f3 Remove Windows style new-line character
commited for Duncan Idaho
2012-05-02 13:01:33 +00:00
Jim Mankovich
90d40c6d7a Document the -N and -R options per tracker ID: 3489643 2012-05-01 19:44:58 +00:00
Jim Mankovich
7733416d2b Commit limits length of user name and password that can be supplied by user.
Password is limited to 16 bytes, resp. 20 bytes, for LAN, resp. LAN+,
interface. User name is limited to 16 bytes, no interface limitations.

Reference: SF.net ID#3184687, ID#3001519

Changes done by Duncan Idaho
2012-05-01 19:09:19 +00:00
Jim Mankovich
5f11bb25b0 Correct Threshold/Discrete Sensor Display - Patch Tracker ID - 3508759 2012-05-01 16:59:23 +00:00
Jordan Hargrave
8de0428bdc Remove unused variables/fix typos
Add ipmi_getsysinfo command
2012-04-30 15:28:56 +00:00
Jim Mankovich
f907245d39 Constrain setting of the username to no greater than 16 characters per the
IPMI specification.   ID 3001519
2012-04-30 12:43:17 +00:00
Jim Mankovich
fbd0c88ae6 Constrain User ID between 1 and 63. ID - 3519225
Fix and testing done by Duncan Idaho
2012-04-27 12:12:56 +00:00
Jordan Hargrave
373e4fe28d Use consistent netfn/cmd for getsysinfo command 2012-03-22 17:08:32 +00:00
Albert Chu
fdf1176fa0 fix manpage misdocumentation on cipher suite privilige configuration 2012-03-06 01:41:50 +00:00
Jim Mankovich
062bd1f9a4 Fix a proplem when using bridged IPMI commands on the lanplus interface (-I
lanplus with -b -t or -m switches)  resulting in "Close Session command
failure".
2012-02-17 21:49:20 +00:00
Jim Mankovich
6e5043f289 sensor units should handle percentage units - ID: 3014014 2012-02-16 12:55:52 +00:00
Zdenek Styblik
83b34749c5 Commit modifies return codes under various circumstances for subcommand LAN.
Return 0 for help. Return <> 0 on error eg. not enough parameters.
2012-02-09 13:51:53 +00:00
Zdenek Styblik
403c86e51c Commit fixes wrong evaluation of is_lan_channel() in find_lan_channel()
introduced by yesterday's changes of 'lib/ipmi_lanp.c'.
2012-02-09 12:40:40 +00:00
Zdenek Styblik
89759cbdec Commit remedies bug introduced by modifications of ipmi_lanp_main() yesterday.
Fixes wrong evaluation of strncmp() in ipmi_lanp_main().
2012-02-09 12:34:18 +00:00
Zdenek Styblik
89243c2929 Feature Requests item #3486218 - remove bloat in 'lib/ipmi_lanp.c'
Commit removes bloat code in ipmi_lan_stats_clear() in 'lib/ipmi_lanp.c' and
replaces duplicate code with call to is_lan_channel().
2012-02-09 12:26:31 +00:00
Zdenek Styblik
9d8aa74a54 Feature Requests item #3486218 - remove bloat in 'lib/ipmi_lanp.c'
Commit removes bloat code in ipmi_lan_stats_clear() in 'lib/ipmi_lanp.c' and
replaces duplicate code with call to is_lan_channel().
2012-02-09 12:22:37 +00:00
Zdenek Styblik
ad4065a370 List of changes in 'lib/ipmi_lanp.c':
* return value != 0 when no or not enough params given
* replaces strtol() calls with str2uchar() ones
* invalid input checking and error messages for such events
* ipmi_lanp_main() got slight work-over
2012-02-08 15:31:00 +00:00
Zdenek Styblik
e230427138 Changes return value of ipmi_lan_stats_get() and ipmi_lan_stats_clear() on
error in 'lib/ipmi_lanp.c'. Changes return value from 0 to (-1).
2012-02-08 14:50:37 +00:00
Zdenek Styblik
4a462cd714 Change return type and value of find_lan_channel() in 'lib/ipmi_lanp.c'
Changes return type from int to uint8 since returned value is being assigned
into uint8_t.
Changes return value from (-1) to 0, because of uint8_t. 0 is considered as an
invalid LAN channel anyway, so there is no reason for returning (-1).
2012-02-08 14:42:47 +00:00
Zdenek Styblik
29d82210b4 Change return value of ipmi_get_channel_medium() in 'lib/ipmi_channel.c'
Return 0 instead of (-1) since ipmi_get_channel_medium() is supposed to return
uint8_t.
2012-02-08 13:40:51 +00:00